[#4009] Clean up usage of merged data #4110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Apr 3, 2024
Comment on lines
18
to
26
| def _get_printable_data(submission: Submission) -> list[tuple[str, Any]]: | ||
| printable_data: list[tuple[str, Any]] = [] | ||
| merged_data = submission.get_merged_data() | ||
|
|
||
| for component in filter_printable(submission.form.iter_components(recursive=True)): | ||
| key = component["key"] | ||
| value = format_value(component, merged_data.get(key), as_html=False) | ||
| printable_data.append((component.get("label", key), value)) | ||
|
|
There was a problem hiding this comment.
This function was already adapted in d7b63bd, and figured it was still relevant as it was kept as well in this commit (while the other uses of submission.get_printable_data() were removed).
In the future, the `data` property could also be removed, to enforce people using the state wrapper instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4110 +/- ##
==========================================
- Coverage 96.10% 96.10% -0.01%
==========================================
Files 730 730
Lines 23089 23079 -10
Branches 2698 2697 -1
==========================================
- Hits 22189 22179 -10
Misses 638 638
Partials 262 262 ☔ View full report in Codecov by Sentry. |
|
Latest is still broken, there's a minimum repro on our test environment. |
Viicos
force-pushed
the
issue/4009-cleanup
branch
from
88d411b to
d6c54da
Compare
sergei-maertens
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4009, #979.
As said in the issue, I'm not able to reproduce the sdk rendering bug anymore on latest.
This PR can safely be reviewed commit per commit.